search

DIAGNijmegen / rse-panimg

Conversion of medical images to MHA and TIFF.
Apache License 2.0
13 stars 5 forks source link

removed fundus image extraction from oct converter #32

Closed amickan closed 3 years ago

amickan commented 3 years ago

Deleted fundus image extraction from oct converter. Currently fundus extraction is not necessary and also not desirable given that there is no way to link the extracted fundus and the oct image together on grand challenge.

jmsmkn commented 3 years ago

Do you also want to remove any unused code from oct_converter?

HarmvZ commented 3 years ago

This PR is a bit too invasive IMO. Sorry @amickan this is my fault, I suggested removing the code but was not clear enough in what to remove exactly. I will make a new PR to temporarily disable fundus processing.

Sidenote for @jmsmkn: We decided to skip processing of fundus images for now until we decide how to handle them correctly. Currently, the only usecase for processing these proprietary formats will be an algorithm that runs only on OCT volumes. Importing the fundus images alongside the volume will then also execute the algorithm on the fundus images (right?) which will fail. To solve this we probably want to connect the images to the correct component interface somehow. Since this is not required for the current usecase we can solve it later.