Profile pages show also completed projects

DIAGNijmegen / website-content

This repository stores all the content for the diag websites.

MIT License

5 stars 74 forks source link

Profile pages show also completed projects #460

Closed nlessmann closed 1 year ago

nlessmann commented 2 years ago

The profile page of a member lists projects, and these currently include completed projects. We need to discuss whether this is the intended behavior and if not implement a fix.

nlessmann commented 2 years ago

The "Projects" page (on the CPG website) splits the projects up into running and finished projects.

The research line pages (on the DIAG website) are manually configured because there is no relationship between projects and research lines - a project lists the people that are involved but not to which research line it belongs. Instead, the research line page lists the projects that belong to the line.

Considerations:

If we eventually replace the "Projects" page on the CPG website with a "Research" page, there could be project pages that cannot be reached anymore. Should we add a feature to the research line pages to show finished projects under a separate header?
On a profile page, we could do the same - either not show finished projects or list them below the running projects as "Past projects" or similar.

martvanrijthoven commented 2 years ago

We can also add a boolean option in the markdown for people pages, such that people can switch between showing completed projects yes/no.

JasperLinmans commented 2 years ago

There are only a few people in our group (staff members) that stay long enough to create an enormous backlog of old projects, and maybe some would actually still like to showcase finished projects. So I agree, having it optional in some way is probably best.

JasperLinmans commented 2 years ago

Discussed during the meeting:

Make every item (projects, software, algorithms, etc.) on the member page optional, and configurable in the markdown file.
Think about which sections exactly (algorithms is currently not implemented).
Make a split between running and past projects. This way, everyone can hide past projects if desired.

martvanrijthoven commented 2 years ago

This has been implemented with a flag show_finished_projects in members md files. default to true I also added option to show projects, software via "sections" field. One thing that could still be implemented ( as Jasper noted) is a split between running and finished projects and show it under two different headers

keelinm commented 1 year ago

Marina would add code so that there would be headers dividing completed projects from running projects

keelinm commented 1 year ago

Fixed by Marina