DIDSR / cpr

Color Performance Review Tool for Endoscopy Devices
Creative Commons Zero v1.0 Universal
5 stars 4 forks source link

The XYZ_1.exe doesn't run #3

Closed Pjcaogthb closed 1 year ago

Pjcaogthb commented 1 year ago

Hi,

We have tried the XYZ_1.exe with MATALB R2022a, runtime ver9.12 and tookboxes installed, but it just shows the initial screen and a few seconds later, closed. We have four independent software consults tried and all got the same results.

Would you please give some advices?

Thanks. PJ

CMBTL commented 1 year ago

Same issue. Has tried another way through MATLAB directly, but always stopping in line 19.

Hi,

We have tried the XYZ_1.exe with MATALB R2022a, runtime ver9.12 and tookboxes installed, but it just shows the initial screen and a few seconds later, closed. We have four independent software consults tried and all got the same results.

Would you please give some advices?

Thanks. PJ

WeiChungCheng commented 1 year ago

Hi @Pjcaogthb and @CMBTL,

The "XYZ_1pager.exe" needs to run in the command mode with two parameters. Please try the following:

• Enter DOS command mode • \cd \Users\xxx\Downloads\cpr\one_pagerXYZ_1pager.exe XYZ_Reference.csv XYZ_Subject.csv

Specify the working directory on your computer. Replace and with your own testing data. Besides the Matlab Runtime, Matlab basic and the toolboxes are not required to run this app. Please let us know if you have additional questions and suggestions.

Thanks, WC

Pjcaogthb commented 1 year ago

Thank you so much for the reply. I works and generated the output figure: One_pager.png. The converted CIELab is graphically displayed in the figure. Is it possible to get the CIELab values? Thanks.

WeiChungCheng commented 1 year ago

@Pjcaogthb:

The current version does not save the numerical CIELAB data. It's a good idea and should be implemented in the next version. Thanks.

WC

WeiChungCheng commented 1 year ago

@Pjcaogthb:

If you have Matlab Image Processing Toolbox, you can use the xyz2lab() function to convert CIEXYZ to CIELAB:

xyz2lab(XYZ,'WhitePoint',XYZ_white)

WC

Pjcaogthb commented 1 year ago

Thanks a lot. We have the Toolbox.

PJ

Pjcaogthb commented 1 year ago

Hi WC,

I noticed the Line 25 in your input file is the same data as No. 19 color patch.

I also like to use No. 19 as the reference white instead of using another separated one.

Is it a common practice to use No. 19 as the reference white?

Thank you so much if you can provide advice.

Thanks. PJ

On Thu, Mar 2, 2023 at 7:09 AM Wei-Chung Cheng @.***> wrote:

@Pjcaogthb https://github.com/Pjcaogthb:

If you have Matlab Image Processing Toolbox, you can use the xyz2lab() https://www.mathworks.com/help/images/ref/xyz2lab.html function to convert CIEXYZ to CIELAB:

xyz2lab(XYZ,'WhitePoint',XYZ_white)

WC

— Reply to this email directly, view it on GitHub https://github.com/DIDSR/cpr/issues/3#issuecomment-1452026954, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWZLGRSWMQI6GY2UGR7BTYDW2CZZJANCNFSM6AAAAAAVM4V53I . You are receiving this because you were mentioned.Message ID: @.***>

-- PeiJie Cao, CTO FemDx Medsystems, Inc

2336 Walsh Ave, #A Santa Clara, CA 95051 Cell: 510-378-1672 www.femdxmed.com

Pjcaogthb commented 1 year ago

Hi WC,

I noticed the Line 25 in your input file is the same data as No. 19 color patch.

I also like to use No. 19 as the reference white instead of using another separated one.

Is it a common practice to use No. 19 as the reference white?

Thank you so much if you can provide advice.

Thanks. PJ

WeiChungCheng commented 1 year ago

Hi @Pjcaogthb,

The following is a technical comment rather than regulatory advice.

Notice that the supplied input files are for testing purposes only. They do not indicate sufficient device performance nor adequacy of the testing data.

You are correct. In these input files, patch #19 is re-used as the reference white. Choosing an adequate reference white really depends on the set-up, output media, measurement method, etc.

Nevertheless, using the white patch #19 in the scene as the reference white for obtaining the ground truth seems to be valid.

WC

Pjcaogthb commented 1 year ago

Thanks! PJ

Pjcaogthb commented 1 year ago

Hi WC,

Could you share the equation to calculate Delta E? I used the Matlab function deltaE(I1,I2,'isInputLab',true), didn't get the same results as your application.

Thanks. PJ

WeiChungCheng commented 1 year ago

@Pjcaogthb:

Please create another issue because it is irrelevant to the title of the current issue.

Thanks, WC