DIDSR / iMRMC

iMRMC: Software to do multi-reader multi-case analysis of reader studies
http://didsr.github.io/iMRMC/
Other
22 stars 17 forks source link

merge from qigong branch #121

Closed qigongFDA closed 7 years ago

qigongFDA commented 7 years ago

1.Create a R project to generate R package for iMRMC and iRoeMetz. 2.Comment out sizing validation code to speed up software.

brandon-gallas commented 7 years ago

Please explain to me why sizing validation is commented out. What is the speed difference? Why do we not need this code? Will this code be uncommented after the package is created? Should we separate the sizing validation from the main work flow used in the package?

qigongFDA commented 7 years ago
  1. Sizing validation code do 8 sizing studies (1 or 3 split plot; paired or unpaired reader and case) for each trail simulation. For one trial we do 1(data) + 8 (sizing) = 9 analysis. I didn't test the speed, but I think it should slow down the code.
  2. We add these codes for validate sizing function. It is for development. For end user, they don't need those results.
  3. Current release version doesn't comment out these code, I think we should do comment these in next version. We only uncomment them when we need to do sizing validation in future.
  4. Now we do sizing analysis analysis right after we finish one trail analysis. As we don't need to do validation very often, I don't think we should separate it.
brandon-gallas commented 7 years ago

I don't like this. If we need the sizing validation elements, we will do one of two things: