Closed brandon-gallas closed 6 years ago
There were errors about the output files written by the java application, which is the basis for the MRMC AUC analyses. It turns out that the CRAN checkers are in germany and when they run the java program their "locale" formats decimals with a comma instead of a decimal. #131
That error has been fixed. I am attaching the current report from the check.
There were notes about some functions did not have a global definition ("no visible global function definition"). This is because the checks are run in a base R environment. It doesn't include the stat package (rnorm and var functions) or the utils package (write.table and read.csv functions).
I asked Frank for help establishing an R installation that follows the guidance ("check your package with the latest development version, R-devel"; http://r-pkgs.had.co.nz/release.html)
He installed the latest development version on his machine and allowed me to log in to run devtools::check()
We had to install some OS libraries in addition to some R packages, but we got it to work. Actually, it worked for Frank, but there was some problem with me running the program. _This is the command that I run in /raida/bdg/000svn/iMRMC.git/trunk/Rpackage/iMRMC/. It works when I run it on perceus but not when I run it on your machine.
_java -jar /raida/bdg/000svn/iMRMC.git/trunk/Rpackage/iMRMC/inst/java/iMRMC-v3p3.jar input.imrmc imrmcDir
Frank got it to work: _If you add -Xmx512m, it works: java -Xmx512m -jar /raida/bdg/000svn/iMRMC.git/trunk/Rpackage/iMRMC/inst/java/iMRMC-v3p3.jar input.imrmc imrmcDir This sets the maximum heap size to 512 megabytes. When I query java it says the maximum heap size is 1 gigabyte, which makes your java tank. But not mine. Weird.
I also had an issue, "Non-standard files/directories found at top level:" I had not formatted the .Rbuildignore file correctly. The best way to do that is to run devtools::use_build_ignore("input.imrmc")
Finally, the package has a couple other notes that I will mention in "cran-comments.md"
It is uploaded to CRAN
Follow the instructions in http://r-pkgs.had.co.nz/release.html
Part of the process is to use the command devtools::build_win()
This command produces all the checks on a windows platform. I think there are commands to check on linux and mac platforms. I will do.