search

DIDSR / iMRMC

iMRMC: Software to do multi-reader multi-case analysis of reader studies
http://didsr.github.io/iMRMC/
Other
22 stars 17 forks source link

Update warning reporting #142

Closed brandon-gallas closed 5 years ago

brandon-gallas commented 6 years ago

When iMRMC is run as a GUI and it encounters a warning reading the input file, a window opens to alert the user. When iMRMC is run within RStudio with output directed to the console, there is no report of the warning.

Please print warnings to standard output before opening the window with the warning. That way, the user can see the warning in Rstudio.

brandon-gallas commented 6 years ago

In addition to the issues about the warning. Please update error reporting. For example, if I read in a file that has a missing truth statement, the GUI will open a window describing the error. image

This error (and others like it) do not get reported to the (output) console, and there is no window to dismiss. In Rstudio, the user does not know what happened. The program hangs. The error needs to be reported to the console, and the iMRMC program needs to be shut down.

qigongFDA commented 5 years ago

I think this has been solved. Please check it.

brandon-gallas commented 5 years ago

Please document how errors are handled before and after the changes and document if all errors and warnings are treated the same way or if there are different groups.

brandon-gallas commented 5 years ago

Please document how errors are handled before and after the changes and document if all errors and warnings are treated the same way or if there are different groups.

qigongFDA commented 5 years ago

Create two methods in commandStartFunction: displayConsoleError, displayConsoleWarning.

For GUI mode, error and Warning will display in a window and print out in console (same as before). For command line mode, the Error and Warning will only print out in console. If it is an error, software will quit.