search

DIFM-Brain / ofpetrial

GNU General Public License v3.0
0 stars 1 forks source link

package dependency #10

Closed tmieno2 closed 4 months ago

tmieno2 commented 5 months ago

@brittanikedge, if you are using a package for a couple of functions, consider taking the codes of the functions and paste them on utility.R. That way, we can reduce the amount of package dependencies. For example, we were using the measurements package, but, we are just using conv_unit. Can you do this check for the packages you added?

tmieno2 commented 5 months ago

We are using json format for unit conversion factors for the inputs. It is probably better to store them as an rds so that we do not have to use jsonlite pacakge. Or csv or any file format that is easy to manually modify and read without any additional package.

brittanikedge commented 5 months ago

@tmieno2 Yes, I'll do this check especially for the functions that I've been working on, such as those related to the report creation. I'm currently working through some errors in the report.

I will also make that change to the conversion table format. I should be able to push these changes along with the updated report function tomorrow. If there are any errors left after that, I will make them specific issues.