Closed brittanikedge closed 4 months ago
@brittanikedge, can you give me an example code of the first case?
@tmieno2 Of course, first I need to see if I can replicate this issue with the package.
@tmieno2 I was able to recreate the errors I saw before with the following combinations:
@brittanikedge, the problems are fixed. But, several things to note.
First, side and head lands are clearly defined only when the field is perfectly rectangular. On the website, I think it is important to let the users know somehow it is a rough (or approximate) length on the sides and top/bottom. They typically should pick a number slightly larger than the acceptable length. If some farmers are really picky about where the edge of the experiment boundary is, then specifying with a single number is not possible. In such case, they need to give us the exact line that represents the edge of the field on ONE side (two sides cannot be respected as plot_with governs the other end when one end is fixed). You should discuss this with Dave. If necessary, I can code that in.
Second, we have never had exactly the side_length and head_length specified by the user (especially the side land, headland should be very close as long as a field is rectangular) reflected on the trial design map.
For now, please double check if the problems above do not happen and close this issue if there is no problem. I only checked with the cases you gave me. You can create a new issue on the feature above if it turns out to be useful.
@brittanikedge, have you had a chance to look at this?
@tmieno2 Yep, I actually tested out another case today to see what would happen with minimal headlands and an angled field. This all looks good. I feel comfortable closing it now.
Problems that have arisen with sidelands: