DIFM-Brain / ofpetrial

GNU General Public License v3.0
0 stars 1 forks source link

missing ab-line #20

Closed tmieno2 closed 4 months ago

tmieno2 commented 4 months ago

@brittanikedge, have we ever had an instance where farmers do not have an ab-line? I was working with the boundary file with a hole and realized ab-line for the field was missing, which resulted in an error. We used to allow the users to provide an angle. It is easy to get that back, but would it be ever useful?

Also, can you share the ab-line for the field?

brittanikedge commented 4 months ago

@tmieno2 On the website, we give them a variety of options to make an ab-line, starting point and angle, drawing a line, or two point. However, the ab-line is constructed as a spatial object, and that is what will be passed to the code. For users of the package, I would say that if we want to provide an option when they don't have a shapefile of the ab-line, the most common use case is when they have two points.

Here is the ab-line for the field. FarmC_FieldZ ab-line.zip

tmieno2 commented 4 months ago

Thanks. Okay, for the user of this package where no interaction is allowed, providing two points would be really hard to do I believe. Let's stick with the current options for now.

brittanikedge commented 4 months ago

I agree, and it doesn't seem like a common use case for someone who would be using the package instead of the website.