search

DIFM-Brain / ofpetrial

GNU General Public License v3.0
0 stars 1 forks source link

respecting rank_seq_as and rank_se_ws #24

Closed tmieno2 closed 4 months ago

tmieno2 commented 4 months ago

Current assign_rates() ignores rank_seq_ws and _as in some cases.

tmieno2 commented 4 months ago

One input case:

if rank_seq_as = NA and rank_seq_ws != NA, just use the regular processing (ignore irregular field, notify the user) if rank_seq_as != NA and rank_seq_ws == NA, make sure the first rate is the one specified by rank_seq_as in the optimizing loop if rank_seq_as != NA and rank_seq_ws != NA, just use the regular processing (ignore irregular field, notify the user)

(Decided against it later)

tmieno2 commented 4 months ago

If neither of rank_seq_as or rank_seq_ws is specified for the first input and one of them a specified for the second, switch the order of processing. Switch back at the end.

tmieno2 commented 4 months ago

generate the "best" rank_seq_ws based on "rank_seq_as" if it is provided and rank_seq_ws is missing.

(Decided against it later)

tmieno2 commented 4 months ago

warnings on provided sequence when design type is ls.

tmieno2 commented 4 months ago

@brittanikedge, just to let you know that we have now rate_jump_threshold parameter for prep_rate() for user to specify the maximum jump allowable.