search

DIFM-Brain / ofpetrial

GNU General Public License v3.0
0 stars 1 forks source link

Message or error when SQ is not in rates list #31

Closed brittanikedge closed 4 months ago

brittanikedge commented 4 months ago

How should we handle not having the SQ in rates? Do we make it an error or do we just add a warning message so that they are aware?

Additional problem: When SQ is not in rates, nothing is applied to headland in trial design.

brittanikedge commented 4 months ago

@tmieno2 Here is something else I noticed while testing some fields today. Any thoughts? For the website, this is no problem, as we will make it an error on the web form if their list of rates doesn't include the SQ.

tmieno2 commented 4 months ago

I feel like for a generic trail design, we should allow for not having status quo rate the same as the rate on the headland. I will fix the problem of not having any rate on headland when rates do not include gc_rate.

tmieno2 commented 4 months ago

@brittanikedge, okay, so gc_rate is actually assigned correctly. It is a problem of not registering it as one of the rates when creating a factor of rates. When that is done, rate in headland is ignored.

brittanikedge commented 4 months ago

Ah, that makes sense. It's just a mapping problem.