search

DIFM-Brain / ofpetrial

GNU General Public License v3.0
0 stars 1 forks source link

fill color scheme of maps #32

Closed tmieno2 closed 4 months ago

tmieno2 commented 4 months ago

@brittanikedge, when I was fixing the assign_rates(), I was checking maps constantly and had trouble seeing whether rates are going up and down. We might want to give other palette options. Not many, but a few, to make high-low rates a bit better. For the report (like a year ago at least), we use the single color with the thickness of color indicating low-high right (green for seed, red for nitrogen)? We probably should give that option.

brittanikedge commented 4 months ago

@tmieno2 Sure, I think we lost the colors in the reports when I moved to using the same figures for viz() and make_report(). So, do you want both of those functions to include a color scheme option? Is there a particular case where someone might want the viridis over say the greens or reds?

tmieno2 commented 4 months ago

On the DIFM website, do you guys use viridi? If no complaints have made, I think we can stick with that color scheme for make_report() and make options available only for viz().

brittanikedge commented 4 months ago

No, we generally use grey and green scales on the website. That is certainly Professor Bullock's preference. I believe viridis came from the viz() function. For the report, we may want to automatically make it grey and green and have options for viz().

tmieno2 commented 4 months ago

Okay, let's do that. Adding grey and green options to viz() and make_report() uses grey or green. There are other things to clean up in viz() (factor issues #32). I will also make changes in prep_rate() to remove all the conversion stuff.

tmieno2 commented 4 months ago

Okay, I ended up making Greens the default. I don't think we need to add other palettes as options. I will talk about what they can do in one of the viginettes if they want to change how maps look.