search

DIFM-Brain / ofpetrial

GNU General Public License v3.0
0 stars 1 forks source link

input_unit_combinations.json and input_unit_conversion #34

Closed tmieno2 closed 4 months ago

tmieno2 commented 4 months ago

@brittanikedge, in your last commit, input_unit_combinations.json was added to inst/extdata. This files does not seem to be in use anywhere. If so, can you remove it? If you intend to use it, it should be placed in data-raw (and the create internal data out of it as we did for input_unit_conversion.json).

brittanikedge commented 4 months ago

@tmieno2 Ah, interesting. That was not intentional. I'll remove that. I was under the impression that we weren't converting any longer, so we don't need it anyway. I will remove it now.

I had a question for you as well. Did you remove the base_rate option? I see one function still in the prep_rate supporting functions, but it isn't being used.

tmieno2 commented 4 months ago

Oh, good catch. I will remove both option and function.

brittanikedge commented 4 months ago

Perfect, then I will do the same with the function that creates text about the base rate in the report. Have you also removed the conversion, or are we keeping it? I'm wondering if we even need the JSONs that are in data-raw.

tmieno2 commented 4 months ago

No, we still have conversion for inputs. Just not base rate. No worries about data-raw files. They are not part of the package anyway.

brittanikedge commented 4 months ago

Okay, and that conversion is using one of the files from data-raw I assume. Okay, I've remove the JSON from inst, so I will close this issue!