trial report: missing input value in replications

DIFM-Brain / ofpetrial

GNU General Public License v3.0

0 stars 1 forks source link

trial report: missing input value in replications #37

Closed tmieno2 closed 5 months ago

tmieno2 commented 5 months ago

Is this by design. I think it is better to have target rate value on the left.

tmieno2 commented 5 months ago

All the issues related to trial report was found when I ran

devtools::load_all()

data(td_single_input)
make_trial_report(
  td = td_single_input,
  folder_path = here::here("debug")
)

brittanikedge commented 5 months ago

Nope, that is not intentional. I'll be working on all of the errors and issues from the vignette today. Most seem simple like this. I hadn't tested an example with three harvester passes. I will fix the text one as well.

tmieno2 commented 5 months ago

Yeah, I think this is a very unusual case, which always creates work for us.

brittanikedge commented 5 months ago

Yep, but it might not be so unusual in Washington for example, so I'm glad you caught it. Sometimes they have quite small harvesters and very wide plots.

tmieno2 commented 5 months ago

Oh, okay. So, I am not just creating work for you for the cases that will never happen. Good.