Dev branch - Githubissues

WillStill commented 2 years ago

New Pull Request This one brings a few new things:

Section and footer elements for each page

Metatags have been added and improved

Favicons have been added
Meta descriptions have been improved for web searches (hopefully)

Condensing of elements and attributes on all pages

h(1-5), a, p, span, ul, and li elements have a single class they refer to at the beginning of the .css for font-size:, color:, font-weight, margin:, padding:, and text-decoration:. Exceptions to these rules include the navigation menu, footer, index page (hoping to change), and anything with text within a large amount of containers (course pages and project page).

Units are now more consistent

rem units are used in place of em or px units. % and vw units can be used instead of rem.
width, height, top, bottom, left, right, some footer elements and media queries still use unresponsive units.

Backgrounds of all the pages are the same

Yuying's pawprint design was placed on a white background that repeats for all pages

Link (a elements) are consistent colors. Visited links, hovered links, and neutral links are different shades of blue.

Last request had a few issues with the consistency of units and other stuff. I was directed to push the consistency changes then create another pull request for the design of the background and other things. I forgot to do this. If you have any issues with any of the bullet points above, I can go back in and change them before the request is merged.

ebeshero commented 2 years ago

@Yuying-Jin and I have been looking at this PR this evening, and find some problems with it--see discussion on Slack.

ebeshero commented 2 years ago

@WillStill I'm closing the PR, but you can keep working in the branch and submit a new one if you like. It might be better to start a new branch from the current version, though, to rethink some of the changes.

ebeshero commented 2 years ago

I updated the comments here after comparing with the existing site. Some problems in this branch (like the nav bar highlighting) are also problems on the published site.

DIGIT-PSB / DIGIT

Dev branch #21