search

DIGImend / digimend-kernel-drivers

DIGImend graphics tablet drivers for the Linux kernel
GNU General Public License v2.0
1.16k stars 172 forks source link

Code correction in the file 'hid-uclogic-params.c' #658

Closed pwrzec1 closed 2 weeks ago

pwrzec1 commented 1 year ago

From the kernel 6.3, you must replace hid_is_using_ll_driver(hdev, &usb_hid_driver) with hid_is_usb(hdev).

I did it as follows:

Code:

#if KERNEL_VERSION(4, 14, 0) <= LINUX_VERSION_CODE
|| !hid_is_using_ll_driver(hdev, &usb_hid_driver)

I changed to:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 3, 0)
|| !hid_is_usb(hdev)
#elif KERNEL_VERSION(4, 14, 0) <= LINUX_VERSION_CODE
|| !hid_is_using_ll_driver(hdev, &usb_hid_driver)
#endif

I tested this change on the HUION Kamvas 13 tablet. This solution works well on my computer. The computer configuration: Distribution: openSUSE Tumbleweed, kernel 6.3.1, AMD Ryzen 7 3700, 64GB RAM. Plasma on X11.

goodspeed34 commented 1 year ago

already fixed in https://github.com/DIGImend/digimend-kernel-drivers/commit/eca6e1b701bffb80a293234a485ebf6b4bc85562