search

DIGImend / hidrd

HID report descriptor I/O library and conversion tool
GNU General Public License v2.0
167 stars 29 forks source link

MinGW/MSYS Additions #15

Closed claydonkey closed 7 years ago

claydonkey commented 8 years ago

The amendments I use currently for a MinGW/MSYS build.

Amended autotool files: Obstack for MinGW : MinGw/MSYS does not currently come with object stack Modified hidrd-convert.c for program_invocation_short_name : MinGw/MSYS does not implement program_invocation

To build:

aclocal
autoheader
autoconf
automake --add-missing
libtoolize
./configure  --prefix=<YOUR_MINGW_PREFIX>

make && make install

To compile for android use the script android64_configure.sh/android_configure.sh

./android64_configure.sh prefix=<YOUR_ANDROID_PREFIX>

Sorry that I removed the comments made previously. I will comment the files later...

claydonkey commented 8 years ago

@spbnick I've added Android configure script and made the configure.ac more realistic

spbnick commented 8 years ago

Hi Anthony, I really appreciate your hard work on making hidrd work in MinGW, but I cannot accept your patches as they are. This is simply too much work for me to clean them up, I don't have that much free time. If you'd like me to merge these, you'll have to work on them some more. If you'd like to do that, please read on. I can promise my help in understanding what needs to be done, but I won't do it for you, nor help with every step. As a plus you'll acquire knowledge useful for contributing to projects in general.

First of all, you'll need to put logically-separate changes into separate commits (search the web on how to do that, look at Linux kernel history for examples). Then get rid of the unnecessary changes, like whitespace changes - they only create noise and make it harder to review patches and search history later. Then put change explanations into corresponding commit messages, not into GitHub code comments, so that they stay in Git history along with the commits themselves. Again look at Linux kernel history for examples.

Lastly, I think we shouldn't be including obstack implementation into hidrd - we don't want to maintain our own copy. Try to find a way to install it as a separate library. Perhaps MinGW has it after all, or somebody else packaged it for you. If you still can't find it, then just rewrite the code to use malloc/free.

Thank you. Feel free asking questions about the above and the code.

claydonkey commented 7 years ago

Hi Nikolai, I totally understand your rejection of the push request. I just wanted to give you a heads up on what is required for an Android/Msys build-able repository. You're right it's not worth the effort to modify your repository with what are in essence just hacks. It was never my intention to "pull request" whitespace changes - I do not want to present you with a signal to noise ratio that makes merging impossible. Given hindsight, a "pull request" was clearly the wrong channel to communicate potentially amendments + I doubt if I will make any more as I hidrd now fits my requirements. Thanks for responding.

spbnick commented 7 years ago

I understand. Thank you for sharing your work. Perhaps you will find the time to clean it up after all some day, or someone else who needs it too does it.