search

DIKU-EDU / remarks

A DSL for marking student work
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Empty points in Assignment-leaves to indicate pending corrections #16

Closed kirkedal closed 7 years ago

kirkedal commented 7 years ago

@oleks comments?

Getting a list of which correction are missing could give a good overview. I could have used it for the Assignments

oleks commented 7 years ago

Yes, that was actually intended. It's just that #10 hasn't been resolved yet.

kirkedal commented 7 years ago

I might not be an error in the check, but could be treated as 0. Then have another command remarks pending that would print a ascii tree structure of the pending corrections.

On 19 January 2017 at 10:02, Oleks notifications@github.com wrote:

Yes, that was actually intended. It's just that #10 https://github.com/oleks/remarks/issues/10 hasn't been resolved yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oleks/remarks/issues/16#issuecomment-273717353, or mute the thread https://github.com/notifications/unsubscribe-auth/AB15lq8FTmt7n8_FHX-6A26dPB8RvIfXks5rTyaYgaJpZM4Ln1Y4 .

oleks commented 7 years ago

On Thu, Jan 19, 2017 at 10:47 AM, Michael Kirkedal Thomsen < notifications@github.com> wrote:

I might not be an error in the check, but could be treated as 0. Then have another command remarks pending that would print a ascii tree structure of the pending corrections.

I like remarks pending.

kirkedal commented 7 years ago

The implementation is build on Data.Tree, which results in large trees. Perhaps make an new implementation of show tree that is more compact.

kirkedal commented 7 years ago

@oleks can you have a look if the new pending-trees also looks nice on Linux. If not I'll update to a more basic char-set.

oleks commented 7 years ago

On Thu, Jan 19, 2017 at 6:36 PM, Michael Kirkedal Thomsen < notifications@github.com> wrote:

@oleks https://github.com/oleks can you have a look if the new pending-trees also looks nice on Linux. If not I'll update to a more basic char-set.

It looks great in rxvt-unicode-256color, Konsole, and xterm! Beware however, in principle, remarks is cross-platform. Someone(tm) should test this on Windows.

kirkedal commented 7 years ago

Yes, that was also why I asked you. Perhaps just revert to the basic character set

On 19 January 2017 at 18:50, Oleks notifications@github.com wrote:

On Thu, Jan 19, 2017 at 6:36 PM, Michael Kirkedal Thomsen < notifications@github.com> wrote:

@oleks https://github.com/oleks can you have a look if the new pending-trees also looks nice on Linux. If not I'll update to a more basic char-set.

It looks great in rxvt-unicode-256color, Konsole, and xterm! Beware however, in principle, remarks is cross-platform. Someone(tm) should test this on Windows.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oleks/remarks/issues/16#issuecomment-273847547, or mute the thread https://github.com/notifications/unsubscribe-auth/AB15lmz8K5CBnQkvILwLszTlF82tU8Qyks5rT6JrgaJpZM4Ln1Y4 .

kirkedal commented 7 years ago