search

DINA-Web / agent-specs

Specifications for the Agent Module
MIT License
1 stars 3 forks source link

Person type should be constant #24

Closed cgendreau closed 4 years ago

cgendreau commented 4 years ago

Person type should be constant 'person' as defined by JSON-API. https://github.com/DINA-Web/agent-specs/blob/master/schema/agent.yml#L174

xuemeigan commented 4 years ago

We are currently using enum of 1 since const type is in the future PR : https://github.com/DINA-Web/agent-specs/issues/13.

cgendreau commented 4 years ago

Not currently, enum is not in the current file.

xuemeigan commented 4 years ago

No, I will send the PR to change to use enum for person type