search

DINA-Web / guidelines

Guidelines on how to create, test and deploy modules within the DINA-project
2 stars 1 forks source link

How to handle file upload? #39

Open cgendreau opened 6 years ago

cgendreau commented 6 years ago

There is a lot of discussion on JSON API issue but it would be nice to pick one for DINA. SeqDB requires file upload functionalities.

I would prefer multipart/form-data over base64 even if it doesn't follow JSON API. Since we can have files like images it would be nice to skip the encoding/decoding part.

gnewton commented 6 years ago

I agree.

Related discussion on out of band (non jsonapi) raw access to objects: https://github.com/DINA-Web/guidelines/blob/master/DINA-Web-API-Guidelines.md RAW Object Access The first example in the table "POST..." should be altered in the following way:

Request mimetype: multipart/form-data Request Body: multipart: two parts: first is json describing binary (in jsonapi format: we need to agree on its content); second is binary payload (i.e. jpeg)

On 4 April 2018 at 16:20, Christian Gendreau notifications@github.com wrote:

There is a lot of discussion on JSON API issue https://github.com/json-api/json-api/issues/246 but it would be nice to pick one for DINA. SeqDB requires file upload functionalities.

I would prefer multipart/form-data over base64 even if it doesn't follow JSON API. Since we can have files like images it would be nice to skip the encoding/decoding part.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DINA-Web/guidelines/issues/39, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwbhptD7QHglIZe7M3ZXtxlR4EARDw6ks5tlSsXgaJpZM4THb8v .