DIPSAS / Dapper.Oracle

Oracle support for Dapper Micro ORM.
MIT License
113 stars 43 forks source link

StrongName / Signed Version #21

Closed Angst003 closed 5 years ago

Angst003 commented 5 years ago

Hi,

Is it possible to have a signed assembly version of this library ? Dapper has a Dapper.StrongName.

epaulsen commented 5 years ago

Sorry for the late response, I somehow missed this issue. As far as I can tell, Dapper it self isn't strongnamed. This is metadata from the latest Dapper version downloaded from nuget.org: image

When PublicKeyToken=null, you can pretty much assert that the assembly isn't strongly named. And as long as Dapper itself don't have a strong name, we cannot strong name either.

Angst003 commented 5 years ago

Hi, I know Dapper is not strongly named but Dapper.StrongName is...

`<?xml version="1.0" encoding="utf-8"?>

Sam Saffron, Marc Gravell, Nick Craver A high performance Micro-ORM supporting SQL Server, MySQL, Sqlite, SqlCE, Firebird etc.. Dapper.StrongName 1.60.1 orm sql micro-orm NuGet.Build.Tasks.Pack, Version=4.9.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35; `
epaulsen commented 5 years ago

Ah, my misunderstanding, sorry. That should be easy enough, just need to add another project file that generates a strong named assembly, and a new nuget package with the strong named assembly in it.

epaulsen commented 5 years ago

There is now a strong-named alternative: Dapper.Oracle.StrongName Exactly the same package, except it is strong-named, and depends upon Dapper.StrongName

Closing issue again.

Angst003 commented 5 years ago

Great thank you very much.