search

DIPSAS / Dapper.Oracle

Oracle support for Dapper Micro ORM.
MIT License
113 stars 43 forks source link

OracleDynamicParameters cannot be read before execution #36

Closed opejanovic closed 4 years ago

opejanovic commented 4 years ago

Hi, first of all - great job. I have been using your libraries for a few weeks and it works very well!

I have noticed that it is not possible to get OracleDynamicParameters values before execution. Having logged DB procedure name and parameter value is extremely important for debugging. Very often we have on production that DB procedure did not returned any value or exception and we need parameter value as an input to reproduce the issue.

I have a solution for this, and I will happily fix it if you allow me to. It is minor code change that you can easily review and approve.

Regards Ogi

epaulsen commented 4 years ago

Thanks for the feedback, glad that our oracle add-on works for you. Any PR that adds value is appreciated, please submit a PR and we will review it shortly. If you can add some unit-tests to verify that the new functionality works out that would be great.

opejanovic commented 4 years ago

@epaulsen I am unable to create a pull request because i have no permission to commit.

epaulsen commented 4 years ago

You cannot push directly to master, need to create PR in a branch created from master. Follow scenario 2 here: https://yangsu.github.io/pull-request-tutorial/ Once a PR is reviewed and accepted I can merge it and create a new version.

opejanovic commented 4 years ago

@epaulsen any ideas? I still have no access to the repository as you can see in comment above.

epaulsen commented 4 years ago

Not sure, I believe it has something to do with my company's org security settings for our github repos. I have asked the admin guy to have a look at it, but that hasn't happenend yet, sorry.

You could try and do a PR from a fork instead? (click "fork" at the top of the repository front page)

opejanovic commented 4 years ago

@epaulsen i managed to create a PR from a fork. Please review the changes.