search

DIRACGrid / DIRAC

DIRAC Grid
http://diracgrid.org
GNU General Public License v3.0
110 stars 173 forks source link

v6r8p11: dirac-pilot flavor wrong #1483

Closed sposs closed 8 years ago

sposs commented 11 years ago

The following block

if os.environ.has_key( 'EDG_WL_JOBID' ):
  cliParams.flavour = 'LCG'
  pilotRef = os.environ['EDG_WL_JOBID']

if os.environ.has_key( 'GLITE_WMS_JOBID' ):
  if os.environ['GLITE_WMS_JOBID'] != 'N/A':
    cliParams.flavour = 'gLite'
    pilotRef = os.environ['GLITE_WMS_JOBID']

if os.environ.has_key( 'OSG_WN_TMP' ):
  cliParams.flavour = 'OSG'

should use elif I think. Otherwise GLITE WNs can become OSG...

atsareg commented 10 years ago

What do you mean ? gLite sites can have OSG_WN_TMP env variable defined ?

sposs commented 10 years ago

Yes... Some sites can be reached by gLite and OSG (BNL in the US is an example).

fstagni commented 9 years ago

Does this really make sense? Anyway we do direct submission to the CEs, we know at submission time CEName and QueueName, so does it really make sense to know? We can know the flavour already at server side.

On a related note, the PilotReference inside the pilot is used up to now so that the Matcher reports that a matched pilot goes in status "Running". This should be a job done by the pilot itself (so independently from where it runs) so this variable can disappear. The other point where this is used is in the StalledJobAgent, to get the status of a pilot. I would say this is not strictly needed, at least not the way it is done.

fstagni commented 8 years ago

Closed as invalid. Also regarding the "PilotReference": it will be changed with the pilot logging system.