[9.0] feat: introduce the `JobWrapperOfflineTemplate` for resources with no external connectivity

DIRACGrid / DIRAC

DIRAC Grid

http://diracgrid.org

GNU General Public License v3.0

113 stars 176 forks source link

[9.0] feat: introduce the `JobWrapperOfflineTemplate` for resources with no external connectivity #7529

Closed aldbr closed 7 months ago

aldbr commented 7 months ago

PR2 from https://github.com/DIRACGrid/DIRAC/issues/7459

JobWrapperLightTemplate: specific template for resources with no external connectivity. Assumes that inputs are available and pre-processing has been done. Solely executes the payload and exits.
A few adjustments in the JobWrapperTemplate covered by extensive tests.

BEGINRELEASENOTES *WorkloadManagement NEW: introduce JobWrapperOfflineTemplate for uses in systems without external connectivity ENDRELEASENOTES

aldbr commented 7 months ago

During the latest Bild-dev meeting, @andresailer suggested adopting a more explicit name to replace JobWrapperLightTemplate. Do you have any suggestions?

Here is a list of potential names for your consideration:

JobWrapperSimpleTemplate
JobWrapperCoreTemplate
JobWrapperBasicTemplate
JobWrapperProcessorTemplate
JobWrapperExecutionTemplate

I am leaning towards JobWrapperProcessorTemplate. What are your thoughts?

andresailer commented 7 months ago

JobWrapperOfflineTemplate, JobWrapperAirGappedTemplate

aldbr commented 7 months ago

JobWrapperOfflineTemplate sound much more explicit and simple, thanks @andresailer!

fstagni commented 7 months ago

https://github.com/DIRACGrid/DIRAC/pull/7570 would provide additional tests for this PR. Can you review that one and (once merged) rebase this PR?

aldbr commented 7 months ago

Thanks @andresailer for the review, I applied the changes. @fstagni I rebased the PR.

I just have one issue with readthedocs but I am not sure what to do with this:

WARNING: Failed to import DIRAC.WorkloadManagementSystem.JobWrapper.JobWrapperOfflineTemplate.
Possible hints:
* AttributeError: module 'DIRAC.WorkloadManagementSystem.JobWrapper' has no attribute 'JobWrapperOfflineTemplate'
* SystemExit: 2

andresailer commented 7 months ago

I think you have to add this to the ignore list https://github.com/DIRACGrid/DIRAC/blob/46adcc03afde8a06eb1d3ab765e1f5c910329097/docs/docs.conf#L35-L36

andresailer commented 7 months ago

Doc still fails, I will try to reproduce locally.

andresailer commented 7 months ago

No, now it is that randomly occuring WorkflowXMLReader issue... I hit rebuild for the docs.