search

DIRACGrid / DIRAC

DIRAC Grid
http://diracgrid.org
GNU General Public License v3.0
113 stars 176 forks source link

[8.0] Remove dead code path in ReplicateAndRegister #7653

Closed chaen closed 4 months ago

chaen commented 5 months ago

@chrisburr @andresailer I need a good review of that one :-) (not the RMS, that's just dead code) Oyr FTS agents had half a billion of proxy files left... not with this anymore I hope :)

BEGINRELEASENOTES

*Core CHANGE: register the DictCache destructor as an atexit handler

ENDRELEASENOTES

chrisburr commented 5 months ago

Isn't the issue here that the FTSAgent isn't passing a deleteFunction so there is nothing to delete the files?

chaen commented 5 months ago

Isn't the issue here that the FTSAgent isn't passing a deleteFunction so there is nothing to delete the files?

I don't think it is, as the ProxyManagerClient which the FTS3Agent uses has the proper delete function https://github.com/DIRACGrid/DIRAC/blob/877f334cf10eff17f046e757e2df82c158de12f4/src/DIRAC/FrameworkSystem/Client/ProxyManagerClient.py#L33

chrisburr commented 5 months ago

Delightful! A global singleton and a reference cycle between DictCache and ProxyManagerClient. It's impossible for this object to ever get garbage collected.

I think the right way to fix this is: https://github.com/DIRACGrid/DIRAC/pull/7666

chrisburr commented 5 months ago

I guess this should be rebased and renamed to just include the dead code removal.

DIRACGridBot commented 4 months ago

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/9805000303

Successful: