DIRACGrid / DIRAC

DIRAC Grid
http://diracgrid.org
GNU General Public License v3.0
110 stars 173 forks source link

[8.0] Added configurable chunksize option to dirac_dms_replicate_and_r… #7672

Closed marianne013 closed 1 day ago

marianne013 commented 2 weeks ago

…egister_request script

BEGINRELEASENOTES

*DataManagement CHANGE: dirac-dms-replicate-and-register-request: Make request chunk size configurable; default behaviour unchanged.

ENDRELEASENOTES

marianne013 commented 2 weeks ago

I left the 'u' out to make it clear that chunksize (line 36) is not the same as chnksize (line 37). At least not in programming terms. I don't do much programming, I need all the help I can get.

featurenotbug

andresailer commented 2 weeks ago

One is a "string" and the other a variable, no harm to use the identical characters. The same is done for catalog. It is much harder to read misspelled text, and remember which misspelling was used.

marianne013 commented 2 weeks ago

The "catalog" is not mine. <digs heels in> Took me some time to work out how to display the brackets.

andresailer commented 2 weeks ago

Yeah, I know, you should do as the romans with the catalog.

marianne013 commented 1 week ago

I still think my way is better, and I can't even hit "commit suggestion" as it will then fail the "commit message formatting" test.

andresailer commented 1 week ago

I can't even hit "commit suggestion" as it will then fail the "commit message formatting" test.

You can "add suggestion to batch" and then type your own commit message. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

marianne013 commented 1 day ago

I've added various 'u'. Everyone happy ?

DIRACGridBot commented 1 day ago

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/9664655301

Successful: