search

DIRACGrid / DIRAC

DIRAC Grid
http://diracgrid.org
GNU General Public License v3.0
113 stars 174 forks source link

Sensitive data filter slightly inverted? #7834

Open sfayer opened 1 day ago

sfayer commented 1 day ago

Hi,

Looking through a log on our DIRAC server, I noticed a slightly weird thing: There is occasionally a redacted log message, but the thing that's removed from the message is the certificate and not the key!

 'proxyString': '***REDACTED***\n-----BEGIN PRIVATE KEY-----\nMIIABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEFABCDEF...===\n-----END PRIVATE KEY-----\n***REDACTED***\n***REDACTED***\n***REDACTED***\n***REDACTED***\n***REDACTED***\n***REDACTED***\n'...

https://github.com/DIRACGrid/DIRAC/blob/e02d21f413d537a232167817f779713a41de6aaf/src/DIRAC/Resources/LogFilters/SensitiveDataFilter.py#L45

Did you perhaps mean to use PRIVATE KEY rather than CERTIFICATE there?

Regards, Simon

aldbr commented 1 day ago

Oops indeed, I will fix that :sweat_smile: