search

DIRACGrid / DIRACOS

Project for creating bundle of DIRAC dependencies.
GNU General Public License v3.0
2 stars 9 forks source link

Add authlib, pyjwt, dominate #178

Closed TaykYoku closed 3 years ago

TaykYoku commented 3 years ago

It would be good to add the following packages to pass the #5149 tests:

petricm commented 3 years ago

I have a bit of problem understanding authlib>=1.0.0 as the current release is v0.15.3 and on authlib it's written

We will drop Python 2 support when Authlib 1.0 is released

chrisburr commented 3 years ago

There is an alpha release of authlib 1 on PyPI but the setuptools metadata states it's only for Python 3.6+.

Do the new token developments need to support Python 2?

fstagni commented 3 years ago

We might as well say that it's only python3, anyway we already can use python3 clients and python3 server is not far away. In this case we don't need DIRACOS support, only DIRACOS2.

TaykYoku commented 3 years ago

Sorry for the delay, I checked on a test installation, we can safely use

authlib .__ version__
'0.15.3'
TaykYoku commented 3 years ago

We might as well say that it's only python3, anyway we already can use python3 clients and python3 server is not far away. In this case we don't need DIRACOS support, only DIRACOS2.

  • How far is authlib 1.0?

0.15.3 is enough for now

  • What has been installed on oauthcertif machine?

python 2, so the remark is correct, need to use version 0.15.3 now

chaen commented 3 years ago

I also would advocate to make it python3 only

TaykYoku commented 3 years ago

I have updated the package versions to support py2 and py3

chrisburr commented 3 years ago

How far is authlib 1.0?

Minus 2 months (March). DIRAC will definitely not be ready fast enough so we might as well use 1.0.0a0 and avoid accidentally using deprecated interfaces.

chaen commented 3 years ago

(hopping they respect the deadline a bit more than DIRAC :-D )

TaykYoku commented 3 years ago

I think if we agree to stop py2 support, we can upgrade authlib and pyjwt packages to the latest versions

fstagni commented 3 years ago

I think if we agree to stop py2 support, we can upgrade authlib and pyjwt packages to the latest versions

In DIRACOS2 only, as DIRACOS will stay for py2 installations.

chrisburr commented 3 years ago

In DIRACOS2 only, as DIRACOS will stay for py2 installations.

There is no need for the packages to be installed in DIRACOS at all

TaykYoku commented 3 years ago

So IIUC we can close issue