search

DIRACGrid / VMDIRAC

DIRAC VM module
http://diracgrid.org
GNU General Public License v3.0
6 stars 25 forks source link

Something missing in VMDIRAC release tarballs for WebApp #152

Open andresailer opened 3 years ago

andresailer commented 3 years ago

The VMDIRAC tarballs don't have the VMDIRAC/WebApp/static/VMDIRAC/VMDirac/build folder, which the WebAppDIRAC has for example

WebAppDIRAC/WebApp/static/DIRAC/ResourceSummary/build/
WebAppDIRAC/WebApp/static/DIRAC/ResourceSummary/build/ResourceSummary.js
WebAppDIRAC/WebApp/static/DIRAC/ResourceSummary/build/ResourceSummary.js.gz
WebAppDIRAC/WebApp/static/DIRAC/ResourceSummary/build/index.html
WebAppDIRAC/WebApp/static/DIRAC/ResourceSummary/build/index.html.gz

Maybe there is something missing in the creation of the release tarballs? The webserver is looking only in the build folder for the VMDirac.js, so I made a link from classes to build on the certification machine to make the VMDIRAC monitor appear for the moment, but this will be gone soon again...

sfayer commented 3 years ago

Hmm, I don't know how the tarballs are built, so I'll assign this to @atsareg for now as I'm sure he'll know.

fstagni commented 3 years ago

The releases are built by the dirac-distribution container which effectively runs what is in https://github.com/DIRACGrid/management/tree/master/dirac-distribution

I am afraid that the case of "Web-related-code" inside another project was never considered -- when I re-made the dirac-distribution mechanism about 18 months ago I forgot about this case. This was an issue also for BelleDIRAC at some point, and to them we just advised to split into 2 different repo (one for extending DIRAC, and another for extending WebAppDIRAC). To be honest, I think it would be better to move this directory https://github.com/DIRACGrid/VMDIRAC/tree/integration/VMDIRAC/WebApp in WebAppDIRAC.