DIRACGrid / diracx-charts

Helm charts for running DiracX
1 stars 17 forks source link

Feat: DiracX-Web port environment variable and node modules size increase #101

Closed Loxeris closed 2 months ago

Loxeris commented 4 months ago

This PR includes two changes:

These changes are necessary as diracx-web transitions to a monorepo structure, making argument passing through Lerna inefficient, and the increased size limit supports the growing dependencies in the monorepo.

The -p argument is specific to the Next.js server and is not applicable to the new library, so passing it would make the command look something like:

lerna run dev --scope diracx-web-components & lerna run dev --scope diracx-web --

Instead of the simpler and more efficient:

lerna run dev --parallel

Additionally, running the library script in the background isn't a good idea because a Next.js error wouldn't stop it, leading to potential issues.

Integration tests now fail without these changes but pass with them, as the dev node script no longer supports the -p argument. Here are the test results: Test without these changes, Test with these changes

aldbr commented 2 months ago

Can you rebase your PR to have a single commit please?