Port Configuration: Updates the port configuration for diracx-web to use an environment variable instead of the -p argument.
Node_Modules Size Limit: Increases the size limit for the node_modules directory.
These changes are necessary as diracx-web transitions to a monorepo structure, making argument passing through Lerna inefficient, and the increased size limit supports the growing dependencies in the monorepo.
The -p argument is specific to the Next.js server and is not applicable to the new library, so passing it would make the command look something like:
lerna run dev --scope diracx-web-components & lerna run dev --scope diracx-web --
Instead of the simpler and more efficient:
lerna run dev --parallel
Additionally, running the library script in the background isn't a good idea because a Next.js error wouldn't stop it, leading to potential issues.
Integration tests now fail without these changes but pass with them, as the dev node script no longer supports the -p argument. Here are the test results:
Test without these changes,
Test with these changes
This PR includes two changes:
These changes are necessary as diracx-web transitions to a monorepo structure, making argument passing through Lerna inefficient, and the increased size limit supports the growing dependencies in the monorepo.
The -p argument is specific to the Next.js server and is not applicable to the new library, so passing it would make the command look something like:
Instead of the simpler and more efficient:
Additionally, running the library script in the background isn't a good idea because a Next.js error wouldn't stop it, leading to potential issues.
Integration tests now fail without these changes but pass with them, as the dev node script no longer supports the -p argument. Here are the test results: Test without these changes, Test with these changes