search

DIRACGrid / diracx-charts

Helm charts for running DiracX
1 stars 17 forks source link

Avoid values with hyphens #83

Closed chaen closed 3 months ago

chaen commented 8 months ago

We have quite a few values (e.g init-sql) which use hyphens while it is bad practice and requires some gymnastic to manipulate (e.g. index .Values "init-sql" "enabled")

https://helm.sh/docs/chart_best_practices/values/#naming-conventions

lipika-27 commented 8 months ago

Hi @chaen, I am interested in contributing to resolving this issue and am open to collaboration. If there are any specific guidelines or preferences, please let me know.

chaen commented 8 months ago

Hi @lipika-27 and thanks for your interest. This is a quite straight forward task, and the guideline is really just the doc I've linked in the issue description. Basically remove all the hyphen words in the values.yaml with camel case (e.g. init-sql -> initSql)

lipika-27 commented 8 months ago

Thanks @chaen, I will start working on this.