DIS-SIN / Busrides

2 stars 2 forks source link

Language synthetizer not switching to french in label #88

Closed stef-barburou closed 2 years ago

stef-barburou commented 3 years ago

this may require more work than worth it, but the label only reads in the current language. to fix this, you'd probably need to use an entire element and have a span inside it withe the lang tag... and then maybe use aria-labelledby to point to it with an ID image

romy-piche commented 3 years ago

Good point ! The author name comes from Ghost directly (the full name of the author), so I guess the problem would be for all the authors with both languages in it.

stef-barburou commented 3 years ago

sounds about right. now this doesn'T cause a LOT of pain for users (I mean .. lets face it, french people are pretty "bonasse" in the public service when it comes to Official languages, and people with assistive technologies don'T complain half as much as I wish they did, so imagine french-assistive-tech-users), and it's very unlikely to be cause for complain, but if we can setup a label outside the element and use it, maybe hide a span for the info that's not needed for sighted users... I wouldn't lose too much sleep over this

stef-barburou commented 2 years ago

spent 1h on this issue found out the french is loaded from ghost, and it seems to be some sort of account name, so we won't be able to modify it to incorporate span tags to mark the language switch.

is this correct @romy-piche ?

if so, nothing much can be done, we can close the ticket

romy-piche commented 2 years ago

Oh yeah ! You are right, the author name comes from ghost directly and it's the account Full Name: https://busrides.ghost.io/ghost/#/settings/staff/da

As you said, I don't think much can be done for this case.

stef-barburou commented 2 years ago

closing.