DISSINET / InkVisitor

An open-source, browser-based front-end application for the collection of complex structured data from textual resources in history and the social sciences into a RethinkDB database for further analysis.
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Switching off global | local validation rules (in Territory-based Validation rules) #1989

Open adammertel opened 3 months ago

adammertel commented 3 months ago

Owner should be able to switch on/off warnings

davidzbiral commented 3 months ago

@davidzbiral Write into https://docs.google.com/document/d/1pmsCjNLHAOA58gVrwV64Qfsp-9wO4kZoXbtyjViMuQA/edit what owner should / should not be able to switch off.

davidzbiral commented 3 months ago

@adammertel , I reviewed this. (Against what I said when we met, the user who has the needed rights should be able to switch off even valency warnings in Statements (mismatch of statement actants with valency frame), because they are disturbing in SumCASTEMO approach.)

Let us do this: Under each T (incl. root T, where, however, only owner can set this; under other Ts anybody who has editing rights to it set this, i.e. any admin, and editors who have this T assigned), in the "Validation rules" section, include the following checboxes (default = all checked in):

Note that in the table, I changed the wording of ca 3 warnings (suggestions highlighted). Please update this in InkV (I changem them in such a way that they serve better the use in this checkbox list.)

I also clarified some texts and the structure for documentation's sake. Have a look at the gdoc and review suggestions.

One important thing that I don't known whether you noted down is: "Only the user with owner rights can set Validation rules for root T. Validation rules for root T are global, and thus display both on Statements using entities which did not pass validation, and on Detail of those entities (at the same place where we display valency warnings for Actions)." If you haven't noted this down yet, please copy it wherever appropriate.

davidzbiral commented 3 months ago

@adammertel In relation to this: should we not make the Entity warning descriptions in the table more editor-readable, less technical, and display them also in this list in the app as tooltip? Happy to rewrite, if I have your agreement that it is a good idea to have the more detailed descriptions of the rules there as mouseover tooltip over each of the checkboxes.

davidzbiral commented 3 months ago

Note that my current extension, much more logical I think, even non-owner can switch some things off for his/her Territory. But not global rules, which concern Entities, of course - these only owner can switch off in the settings of root T.

adammertel commented 3 months ago

I have moved this issue to 1.4.1

davidzbiral commented 3 months ago

@adammertel Is anything more needed from me now for this issue?

adammertel commented 3 months ago

@davidzbiral no I think this is clear for now. Just moved to 1.4.1 so we can focus on the other things.