DISSINET / InkVisitor

An open-source, browser-based front-end application for the collection of complex structured data from textual resources in history and the social sciences into a RethinkDB database for further analysis.
BSD 3-Clause "New" or "Revised" License
10 stars 3 forks source link

Login issue #2181

Closed adammertel closed 1 month ago

adammertel commented 3 months ago

Inspect the situation when the inactivated user cannot pass the login page even though the toast says they are signed in.

image

adammertel commented 3 months ago

Might have been fixed by changes in #2133, where we disabled the password re-creation when the user is not verified yet

davidzbiral commented 3 months ago

@adammertel Sounds like a solution - so how about you test this and then close?

adammertel commented 3 months ago

@Ptrhnk when you have time, could you please recheck the user story for registration, activation, and log in to check if you can reproduce this behavior after the last changes we made, and close this issue?

Ptrhnk commented 1 month ago

The question was "inactivated user cannot pass the login page even though the toast says they are signed in" Now it says user is not active and log in is not allowed which seem correct to me. I've also tested the verification and activation / deactivation.

davidzbiral commented 4 weeks ago

@Ptrhnk I think the issue was about a user "not yet activated" rather than set inactive, but we can put the matter to rest because it is not described enough.

Ptrhnk commented 3 weeks ago

@davidzbiral Inactivated doesn't even have password so it shouldn't be possible to even click on the log in. When I write some random password it says that user is not activated so I think it's solved if this is the exact case.