search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.18k stars 149 forks source link

Problem with host reset on nightly #253

Closed fotisandstuff closed 2 years ago

fotisandstuff commented 2 years ago

In win64 nightly 62181c10 , I have a problem with drum beats like the ones in the patch "falkTX_-_Salomonis-MonoRegen.vcv". The snare goes out of sync many times, and the Aria Salvatrice sequencers are also affected. I temporarily solved the problem by routing the snare and the sequencers' "Reset" inputs to Host Time's "Playing" output instead of its "Reset" output. I use VST2 CardinalSynth on Reaper v6.59 (Windows 10 x64).

dromer commented 2 years ago

Yup, I'm also seeing an issue with the Reset output of Host Time. This is also with the 22.05 release for me, not just local or nightly builds.

In Carla it's only an issue with the VST2, and it seems there the Reset output triggers every bar. In Bitwig however this is an issue with both VST2 and VST3 and there the Reset output seems to be triggering a lot, and at random.

With jack standalone I do not have any problems (and since that's where I do most of my testing I didn't spot this one yet).

fotisandstuff commented 2 years ago

I tried the latest nightly in Reaper. The VST3's seem to work correctly, but the problem persists in the VST2's.

dromer commented 2 years ago

I somehow feel this is when it broke: https://github.com/DISTRHO/Cardinal/commit/c46d659340525f963c95a58747d06deabac9bd9b However I see there is a new commit from last night, will test it when I get home.

fotisandstuff commented 2 years ago

The issue still exists in the latest nightly.

dromer commented 2 years ago

I tried to revert the commit I mentioned, but this gives the exact same result for me. Both VST2 and VST3 just have a super random reset output in bitwig.

dromer commented 2 years ago

Should be fixed by https://github.com/DISTRHO/Cardinal/commit/ec2222be8514140d8a935022d8e1bb00e17df340

Works for me with vst2 and vst3 in both bitwig and reaper!

fotisandstuff commented 2 years ago

Yessss! It's fixed!!!