DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.28k stars 155 forks source link

Cardinal branded modules break the functionality of stoermelder's STRIP #472

Open maxigaz opened 1 year ago

maxigaz commented 1 year ago

STRIP from stoermelder can be used for bypassing all the adjacent modules to the left or right with a press of a button. (For this to work, all the modules have to be right next to each other.)

In Cardinal v22.12 (LV2) running under Arch Linux, if one of the adjacent modules has the Cardinal brand, all the other modules beyond that one will be ignored when I click on the 'Switch strip off' or 'Switch/toggle strip on'.

Here's a screencast demonstrating the issue. In each row, I added STRIP, some random modules, and in certain rows, I also placed Cardinal Host MIDI or Cardinal Host MIDI CC somewhere between them.

(The only change I made to the settings of STRIP is that I set the Port/Switch On mode to Toggle in its context menu, so you can see me click on a single button instead of two, which would be the default behaviour.)

https://user-images.githubusercontent.com/10419911/210411797-143977d5-bc23-4f1a-81fc-4136f6b85878.mp4

Another interesting observation is that although the text module also has the DISTRHO/Cardinal brand, it doesn't affect the behaviour of STRIP in any way.

falkTX commented 1 year ago

thinking about it, might be due to STRIP accessing engine->modules, which the hardware-related "host" modules do not get added in. if this theory is correct, then glBars, Blank, Carla and Ildaeil would also work correctly.

maxigaz commented 1 year ago

if this theory is correct, then glBars, Blank, Carla and Ildaeil would also work correctly.

I can confirm that STRIP works with all these modules.