search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.22k stars 153 forks source link

Add support for setting host parameters in OSC #491

Closed shimaore closed 1 year ago

shimaore commented 1 year ago

This is meant to be used by e.g. small electronic widgets providing live values from potentiometers, switches, …

shimaore commented 1 year ago

I had a quick look at the CI reports and seeing linking issues on MacOS + Windows (due to JUCE symbols if I understood properly) + memleak around BaconMusic:KarplusStrongPoly (unrelated to the changes in this PR as far as I can tell).

Let me know if there's anything I can do to move things forward :hugs:

shimaore commented 1 year ago

I noticed the linking errors happen in Creating LV2 plugin UI for CardinalMini. There are earlier linking stages that perform well (e.g. building standalone apps, Creating LV2 plugin for Cardinal, etc).

shimaore commented 1 year ago

(I rebased, noticing main branch had related changes.)

falkTX commented 1 year ago

GIve me time to get the main branch up and working again, there are some recent breakages to resolve. Just very little time for that at the moment. Will do a proper review after that

shimaore commented 1 year ago

No rush :) I was just trying to see if I could help move things but that's way beyond my reach =)

falkTX commented 1 year ago

Merged a slightly tweaked version in 61796c31797b2fdaf0ca6f26bc8dc1fdffff9a31 Thanks!