DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.22k stars 153 forks source link

Add Sculpt-O-Sound Vocode-O-Matic module #505

Closed farlukar closed 5 months ago

farlukar commented 1 year ago

Builds OK. plugin.json explicitly has GPL-3.0-or-later for the software; graphics license is mentioned as CC0 in LICENSE.txt, but the newer README.md says CC BY-NC-ND 4.0. Can it considered to be the latter or should I ask the author to clarify?

farlukar commented 1 year ago

Ugh, I managed not to get the repo included.

dromer commented 1 year ago

Always better to ask for clarification.

The Non-Derivative would need an explicit permission if we want to create a dark mode render as well.

farlukar commented 1 year ago

I asked; it's specifically CC BY-NC-ND 4.0 (as now mentioned in the changed LICENSE.txt)

farlukar commented 1 year ago

Most build failures look like GitHub outages?

falkTX commented 1 year ago

Please rebase against latest main branch. the windows CI builds are still broken, but the others are ok

farlukar commented 1 year ago

(I know sod all about git, sorry)

falkTX commented 5 months ago

I cleaned up the PR and created #635 based on it, but it is a "wont-fix" as the modules require 44.1 kHz to work properly which is a blocker.