search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.22k stars 153 forks source link

Sapphire v 2.2.2: Added new module Tube Unit. #508

Closed cosinekitty closed 1 year ago

cosinekitty commented 1 year ago

This adds a new module called Tube Unit to my Sapphire plugin.

When I submitted the initial PR for Sapphire back in December, you mentioned that it wasn't helpful that I used the main branch, because it messed up your automated tests. I created a topic branch tubeunit this time for this PR. I hope I'm doing this correctly so that you can test before merging this time.

Please let me know if there is a better way to do this, and if so, I will fix it.

Thanks!

cosinekitty commented 1 year ago

The failures in win32 and win64 appear to match the failures in the main branch tests, so I'm assuming those aren't mine.

falkTX commented 1 year ago

Thanks!