DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.28k stars 155 forks source link

Search field issues #513

Open alltiagocom opened 1 year ago

alltiagocom commented 1 year ago

I noticed a few issues when I open them modules page and I use the Search field:

1 - If I type something and then I click CMD+A to select all text, it doesn't select it. At least in Logic. I see Logic's Edit tab flashing, meaning it seems to be picking the Select All for Logic instead of Cardinal, but it doesn't even select anything inside my project anyway.

2 - If I have something inside the field, it would be expected that when we double click it, it would highlight the whole text so we could for example delete that text. It doesn't

3 - If I have something in the field and I click after the last letter, the cursor doesn't go to the last position after the last letter, it goes to the second to last. For example if I have "filter" instead of being filter| it shows filte|r so if I want to delete the word (besides the fact that it doesn't work when I double click it as I mentioned), I always have to click the right arrow to move it to the last position.

4 - Pressing and holding the DELETE / BACKSPACE key doesn't keep deleting characters. It deletes 1 and stays there so if I have a long word like "oscilloscope" and I want to delete it (since highlighting doesn't work and clicking after the last letter brings me to the second to last position) I have to click the right arrow, then I have to hit DELETE 12 times.

GBaige commented 1 year ago

Can confirm these issues in all Cardinal variants except LV2, 23.02, Windows 11, REAPER 6.67.

falkTX commented 1 year ago

most of these are never going to be solved due to hosts wanting keyboard input for themselves, for special keys, but then the plugins also wanting those. the fight never stops.. I much rather give this decision to the host, a few of them allow to pass special keys into plugin UIs so that is the best approach. If you DAW doesnt have this option, ask them to implement it

alltiagocom commented 1 year ago

"most of these"... does it mean "some" could/will? If so, which?

falkTX commented 1 year ago

I am not much aware which ones exactly do it, Ardour for sure does. I think reaper has a hidden setting somewhere for it too

alltiagocom commented 1 year ago

I was referring to what you said ("most of these are never going to be solved") so I'm assuming some of them can be solved without relying on the DAW, right? For example, when I click inside the search field after the last character, the fact that the cursor is not going to the end of the word, but it goes to the second to last, that seems more like a Cardinal bug (or maybe VCV Rack bug, I don't know), not so much related to the DAW. Also, double clicking a word inside the field, doesn't select it, which is something pretty standard, so I am wondering if this is something that could be fixed? Kapture 2023-03-16 at 23 06 02

falkTX commented 1 year ago

those 2 yeah, what is unsolvable without ugly hacks that host will override on the next version is grabbing all keyboard input for the plugin GUI. the lack of keyboard repeat and sometimes keystrokes missing are cardinal side issues. the rest (weird caret position, double click selection) are also present on VCV Rack.