DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.22k stars 153 forks source link

Display settings revert themselves after closing #534

Closed pastarat closed 11 months ago

pastarat commented 1 year ago

cardinalbug When I enable light mode or change the cable tension, these settings automatically reset after closing FL Studio (v21.0.3)

I tried changing the settings and then saving a project. That still resets the color mode, but not the cable tension.

Affected Cardinal versions: 64-bit Windows VST3 23.02, 5307b9f

dromer commented 1 year ago

Hmm, would indeed expect all of this state to be saved with the project. For me this has been the case so far (but I never switch light-mode so maybe that's why I never noticed).

jn64 commented 1 year ago

In my test, all the other appearance settings (zoom, cable opacity etc) were saved, but light mode was not (it reverts to dark mode).

Cardinal LV2 23.02 Host: Carla 2.5.5 OS: Fedora 38

falkTX commented 1 year ago

this is fixed in latest git and will be part of the next release in 13 days

pastarat commented 1 year ago

This issue is still present in version 23.07

falkTX commented 1 year ago

I cannot confirm, at least on standalone it behaves as expected.

when closing cardinal you should see a line like this:

[3.813 info Rack/src/settings.cpp:491 save] Saving settings /home/falktx/.config/Cardinal/main.json

and that file will have theme mode inside it, like so:

"uiTheme": "light",

When the ui theme is "light", it will make the dark mode off when starting up a new instance.

jn64 commented 1 year ago

I also cannot confirm. It is fixed for me in 23.07. I tested standalone normal and Mini, and lv2 normal and Mini in Carla host on Linux.

pastarat commented 1 year ago

I meant to say it's the 64-bit VST3 version (in FL Studio 21) that won't save the settings. I tried changing the display to light mode in the standalone version, and it worked fine because the settings were stored in the native.json file.

falkTX commented 1 year ago

the plugin version will save to fx.json or synth.json or main.json, depending on the variant. could be that the settings only apply to new instances, not previously saved ones though

falkTX commented 11 months ago

Fixed in 23.10 release, there was an issue saving user preferences under Windows