search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.22k stars 153 forks source link

Mini LV2 loads/saves settings twice; once to wrong location #552

Open jn64 opened 1 year ago

jn64 commented 1 year ago

Cardinal 23.07, in Carla host on Fedora 38

Cardinal LV2 loads settings from ~/.config/Cardinal/main.json once, when the plugin is added to the host. Then it saves the settings once, when the plugin is removed from the host.

Cardinal Mini LV2 is different:

  1. When added to the host, it loads settings from mini.json in the working dir (wherever the host was launched from)
  2. When opening the GUI, it loads settings from ~/.config/Cardinal/mini.json
  3. When closing the GUI, it saves settings to ~/.config/Cardinal/mini.json
  4. When removed from the host, it saves settings to mini.json

Assuming the behaviour of Cardinal LV2 is intended, then all 4 steps are bugs. 1 and 4 are in the wrong location, and 2 and 3 shouldn't happen at all.

falkTX commented 1 year ago

this is normal and expected, except the missing location and using CWD. the mini variant has split dsp/ui, which means it loads the config from dsp side, then it also loads config from UI side.

weird that config dir fails in one of those cases though.. likely something just not being initialized properly