DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.22k stars 153 forks source link

Dependancies not listed in build instructions #556

Closed riban-bw closed 1 year ago

riban-bw commented 1 year ago

The build instructions in https://github.com/DISTRHO/Cardinal/blob/main/docs/BUILDING.md does not list autoreconf as a dependency. Builds fail if this package is not installed. Need to add to the Debian dependencies:

dh-autoreconf

and similar for other platforms

falkTX commented 1 year ago

That is only needed if you use the default vendored libraries. For packaging distros tend to use the SYSDEPS=true option which skips the need for autoconf/automake stuff.

The only weird real dependency is cmake, due to surge-xt things.

Need to find a nice way to describe the situation in that file... :thinking:

riban-bw commented 1 year ago

Should SYSDEPS=true be the default?

falkTX commented 1 year ago

No, because it puts the burden on the builder to provide a few extra libs. If we want the build to be as simple as possible, the dependencies also need to be as little as possible.

riban-bw commented 1 year ago

There is already a section in the build instructions for dependencies for SYSDEPS=true. Should you just add dh-autoreconf to that section?

falkTX commented 1 year ago

dh-autoreconf is debian specific though, correct would be either autoconf or automake, not really sure now, maybe it needs both

riban-bw commented 1 year ago

Indeed but there is a dedicated section in the page for Debian dependencies for SYSDEPS=true into which this specific dependency can be added.

riban-bw commented 1 year ago

Also missing dependency: libfftw3-dev