search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.22k stars 153 forks source link

Add EnigmaCurry #573

Closed EnigmaCurry closed 1 year ago

EnigmaCurry commented 1 year ago

I am starting to test my plugins in Cardinal. This is not ready to merge yet, but if you see some stuff that needs to change, please let me know.

falkTX commented 1 year ago

the setup so far looks ok. but the readme and license information is missing

EnigmaCurry commented 1 year ago

the setup so far looks ok. but the readme and license information is missing

I'm not sure what you mean, my plugin repo has a readme and a license, and both linked in plugin.json. Do you mean adding to docs/LICENSES.md? Where else?

falkTX commented 1 year ago

the last one is not needed, please revert it. likely you have some build files still around that generate the conflict. there is always only a need to set the custom for 1 side, not both.

the license stuff needs to be filled regarding artwork, on the same file you modified but further down. we need to specify all the licensing for the files included in the repo, as a way to alleviate the burden for distribution packages.

then it is just also updating the cardinal main readme to mention your modules being part of it.

falkTX commented 1 year ago

this seems good to me know, anything else still missing or is this okay for merging?

EnigmaCurry commented 1 year ago

Yea, looks like everything works now, thank you very much!

falkTX commented 1 year ago

ok lets merge! thanks