search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.22k stars 153 forks source link

CVfunk add Magnets #628

Closed codygeary closed 6 months ago

codygeary commented 6 months ago

Starting a new PR, I reupdated my branch. I made a new module called Magnets, so here it is added. Cheers!

dromer commented 6 months ago

This all builds and runs fine. Only minor issue I see with Strings is that the labels next to each row are quite unreadable in light mode:

The labels underneath do switch to dark, but the ones on the side do not.

codygeary commented 6 months ago

if you switch between light and dark mode the font color should update when you either reload the patch or drop another module. (There's a way to update the panels more dynamically, but I haven't figured it out just yet..)

codygeary commented 6 months ago

Ah ha! I figured out how to make this font color changing code much more elegant, it turned out to be easy to fix afterall. I'll update this PR later today with it

dromer commented 6 months ago

Looking good. I think the build failures were a glitch in GH Actions, will try to restart them once that button is available.

codygeary commented 6 months ago

https://patchstorage.com/cv-funk-cardinal-demo-hexmod-oscillator/