DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.29k stars 154 forks source link

add LOGinstruments #656

Open kawa-sanmyaku opened 7 months ago

kawa-sanmyaku commented 7 months ago

MOD builds fail, I might need some help with that >.< @taji feel free to test the modules once artifacts are produced here

kawa-sanmyaku commented 7 months ago

Only linux artifacts were generated; sorry about that, not sure what happened there

EDIT: oh dear, lol

kawa-sanmyaku commented 7 months ago

A screenshot from a local build image

taji commented 7 months ago

~MOD builds fail, I might need some help with that >.<~ Success! @taji feel free to test the modules once artifacts are produced here, ~or check the artifacts in the fork~ EDIT: nvm, the artifacts are gone after a workflow re-run of failed jobs :( woe

@washikano : I'll monitor this PR thread and test when artifacts are available. Thanks. :-)

taji commented 4 months ago

@washikano, checking in. Any progress on this? I see that the CI is still stalled?

kawa-sanmyaku commented 4 months ago

@washikano, checking in. Any progress on this? I see that the CI is still stalled?

Sorry, the modaudio build fails, and haven't had time to look into why :( to be completely honest last time I had an issue with the modaudio builds I was completely clueless, I'll see if I can look into it this weekend and merge main

The rest of the builds seem to build fine though ^^ you can download one those artifacts for now if you like

Don't expect this PR to be merged soon/this year though, there are other priorities

falkTX commented 4 months ago

CI has been fixed, please rebase against the latest main branch.

falkTX commented 4 months ago

that modaudio one is an odd one, that code seems to be optimized in such a way that triggers the use of libgomp, which is used for math stuff. nothing for you to do, I will have to check where this lib is available and make sure it is present in the post-build steps