DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.07k stars 141 forks source link

port rkukau plugins? #657

Closed RustoMCSpit closed 2 months ago

RustoMCSpit commented 2 months ago

Description

https://github.com/ryukau/VSTPlugins/issues/2

dromer commented 2 months ago

I'm not sure what your question is, but unless there is a project implementing these this is not going to happen.

RustoMCSpit commented 2 months ago

I'm not sure what your question is, but unless there is a project implementing these this is not going to happen.

it was a suggestion if you wanted to

dromer commented 2 months ago

We can integrate such a project if it exists, but this is completely out of scope for Cardinal to do.

Do note that Ryukau plugins do not have compatible license with Cardinal, so this will actually not be possible to begin with.

RustoMCSpit commented 2 months ago

Do note that Ryukau plugins do not have compatible license with Cardinal, so this will actually not be possible to begin with.

it's under gpl3?

RustoMCSpit commented 2 months ago

We can integrate such a project if it exists, but this is completely out of scope for Cardinal to do.

right so cardinal needs vcv to port it and then it forks that

dromer commented 2 months ago

it's under gpl3?

It needs to be GPL3-or-later.

RustoMCSpit commented 2 months ago

it's under gpl3?

It needs to be GPL3-or-later.

?? whats the difference...?

RustoMCSpit commented 2 months ago

it's under gpl3?

It needs to be GPL3-or-later.

contact the dev to change their licensing, im not following on what the difference is

dromer commented 2 months ago

im not following on what the difference is

https://spdx.org/licenses/GPL-3.0-or-later.html

It means that the code can be used with GPLv3 or any later version of the GPL (ie. v4 or v5 etc.) This needs to be explicitly mentioned by the author, otherwise it's GPLv3-only which is not wanted in the Cardinal project.

RustoMCSpit commented 2 months ago

im not following on what the difference is

https://spdx.org/licenses/GPL-3.0-or-later.html

It means that the code can be used with GPLv3 or any later version of the GPL (ie. v4 or v5 etc.) This needs to be explicitly mentioned by the author, otherwise it's GPLv3-only which is not wanted in the Cardinal project.

i see, so whatever the future of gpl is? so it is compatible but it isnt wanted. please contact the devs to change their licensing and talk about integration

dromer commented 2 months ago

No, as I said this is completely out of scope for Cardinal.

If you want to see that code integrated you'll have to do the work.

RustoMCSpit commented 2 months ago

No, as I said this is completely out of scope for Cardinal.

If you want to see that code integrated you'll have to do the work.

oh alright fair nuff sorry forgot

RustoMCSpit commented 2 months ago

https://github.com/ryukau/VSTPlugins/tree/master/common/dsp

for anyone who sees this, this is where the DSP is

dromer commented 2 months ago

@RustoMCSpit you might have better luck asking on the VCV forums: https://community.vcvrack.com/c/development/8

And what you linked is only the shared bits, not the plugin DSP.

RustoMCSpit commented 2 months ago

And what you linked is only the shared bits, not the plugin DSP.

oh whoops lol! as this project is gpl, can vcv do it?

RustoMCSpit commented 2 months ago

@RustoMCSpit you might have better luck asking on the VCV forums: https://community.vcvrack.com/c/development/8

And what you linked is only the shared bits, not the plugin DSP.

could you link the actual dsp sorry