search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.07k stars 141 forks source link

Sapphire v2.4.4 #663

Closed cosinekitty closed 1 month ago

cosinekitty commented 1 month ago

This brings Cardinal in sync with VCV Rack at Sapphire v2.4.4. Minor UI improvements.

Corrected C++17 build problems for the Sapphire plugin: I learned not to put anything fancy in plugin.cpp or plugin.hpp! Cardinal's C++11 code must be able to include plugins/Sapphire/plugin.hpp, so I can't put any C++17 code there.

This frees me up to use std::clamp, std::make_unique, etc.

cosinekitty commented 1 month ago

OK, I can see I have a little work here. I know what's going on and how to fix it.

cosinekitty commented 1 month ago

I believe this PR is ready now.

dromer commented 1 month ago

Thnx!