search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.07k stars 141 forks source link

Wavetable VCO > Download Extra Wavetable Content Causes Ableton To Crash #674

Open wyhinton opened 1 month ago

wyhinton commented 1 month ago

Version

24.04

Plugin type

VST3

OS

Sonama 14.3.1 (23D60)

DAW / Host (if applicable)

Ableton 12.0.1

Description

New to cardinal so not sure if this is the correct place to raise an issue regarding a particular module or if it should be raised on that modules own repo. But as the title describes and as shown in video, clicking "Download Extra Wavetable Content" for the Wavetable VCO causes Ableton to crash. No particular context or setup is required to reproduce, seems like clicking it at any point causes the crash.

https://github.com/DISTRHO/Cardinal/assets/38958118/eeb640db-f350-4bdb-9522-6962e3578aa9

dromer commented 1 month ago

Hmm, on the standalone I see this in the console:

terminate called after throwing an instance of 'rack::Exception'
  what():  Unarchiver could not open archive /home/dreamer/Documents/SurgeXTRack/SurgeXT_ExtraContent.tar.zst: Failed to open '/home/dreamer/Documents/SurgeXTRack/SurgeXT_ExtraContent.tar.zst'
Aborted

The tricky thing is that we don't like Cardinal to connect to outside resources, but this module requires to be able to download from the internet: https://github.com/surge-synthesizer/surge-rack/blob/main/src/VCO.cpp#L102-L121

A work-around is to download this file manually and place it in the Documents/SurgeXTRack/ location (will be different based on your OS). Make sure to call it SurgeXT_ExtraContent.tar.zst as the downloaded file is called SurgeXTRack_ExtraContent.tar.zst

falkTX commented 1 month ago

this module requires to be able to download from the internet: https://github.com/surge-synthesizer/surge-rack/blob/main/src/VCO.cpp#L102-L121

this is nasty errr. I understand why they do it, but this download will just freeze the UI on the main VCV Rack builds. Specially noticeable if the connection is slow. Then it does not check if the download succeeded, it just tries to extract it.

I think best we can do here is to patch surge to display some text explaining what to do, with the link to the download and the also user folder.

falkTX commented 1 month ago

or alternatively dont even show that menu option since it wont work on cardinal