DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.29k stars 155 forks source link

Drum Sequencer Reset pattern always overwritten #716

Open FogLizard opened 1 month ago

FogLizard commented 1 month ago

Version

24.09

Plugin type

VST3

OS

Arch Linux

DAW / Host (if applicable)

Ardour 8.9.0

Description

Drum Sequencer DK from SV Modular upon Reset always overwrites first pattern bank with pattern from the bank where playback was stopped instead of just resetting to first pattern and first step when playback is restarted from auto return to marker. This bug makes one go back to plugin GUI to manually reset pattern back to the first one every time before starting playback or copy/pasting first bank every time to manually return to original overwritten pattern to fix this issue. This is extremely annoying and it makes iterative music development near impossible. Please fix this. Screenshot_20241019_164234

dromer commented 1 month ago

@FogLizard does this only occur in Cardinal or can you reproduce this in VCV Rack?

FogLizard commented 1 month ago

@dromer I've downloaded free VCV Rack 2.5.2 standalone and there are no drum sequencers. I have no idea how to check this, I don't have pro plugins or anything else to check.

dromer commented 1 month ago

This is not a "Pro" plugin, but an opensource one.

Can you share a patch that replicates the issue so others can test and confirm it?

FogLizard commented 1 month ago

Here's the patch. I can't find where to download the free VCV plugin.

dromer commented 1 month ago

We don't see the patch file anywhere. You will likely have to put it in a ZIP file, or you can upload it at patchstorage.com

For VCV you need to have an account and enable this module in the official library: https://library.vcvrack.com/DrumKit/Sequencer

FogLizard commented 1 month ago

Zip file gets rejected for some reason too. Patch is available by link below: http://191.101.33.198/drum1.vcv

dromer commented 1 month ago

Thank you!

I'm trying to reproduce this in VCV and it seems that it is specific to Cardinal.

We have some minor patches to the DrumKit modules and I suspect that somehow this is breaking the behavior: https://github.com/SVModular/DrumKit/compare/v2.0...CardinalModules:DrumKit:cardinal/v2.0.1#diff-7db98b71809cfb19499d5724bd2b6f4502e147ba7c235b900c3d5ce591beefbfR87-R94